[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 24 10:08:26 PDT 2018


Szelethus added a comment.

I'd also like to point out that as I mentioned before, the checker's name itself is misleading (it is a leftover from an earlier implementation of  this checker). Here are just some ideas I came up with:

- UninitializedObjectChecker
- UninitializedFieldsChecker
- UninitializedFieldsAfterConstructionChecker
- UninitializedMembersChecker
- UninitializedMembersAfterConstructionChecker

Of these I like the first the most, but I'm open for anything, if you have an idea for it.

In https://reviews.llvm.org/D45532#1075789, @NoQ wrote:

> Guys, what do you think about a checker that warns on uninitialized fields only when at least one field is initialized? I'd be much more confident about turning such check on by default. We can still keep a `pedantic` version.


Sounds good! I just finished implementing it along with a few minor (like some TODOs and fixes according to inline comments) and not-so-minor (like ignoring fields from system headers)  changes. I'll update the diff and post results on it once I finish checking the LLVM/Clang project. I feel very confident about the upcoming version.


https://reviews.llvm.org/D45532





More information about the cfe-commits mailing list