[PATCH] D44882: [clangd] Implementation of workspace/symbol request

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 24 09:16:50 PDT 2018


malaperle added a comment.

In https://reviews.llvm.org/D44882#1076864, @sammccall wrote:

> So this fails if there's no standard library available without flags, which is the case in google's test environment to ensure hermeticity :-(
>
> In the short-term, we've disabled the test internally - did it trigger any buildbot failures?
>  In the medium term we should probably find a better way to test this :(


No buildbot failures yet. But I suggest we just remove the test and add it back when we collect more symbols, i.e. in main files. WDYT?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44882





More information about the cfe-commits mailing list