[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Otherwise LGTM.



================
Comment at: lib/CodeGen/CGCUDANV.cpp:51-52
   llvm::Constant *getLaunchFn() const;
+  std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const;
+  std::string addUnderscoredPrefixToName(CodeGenModule &CGM,
+                                         StringRef FuncName) const;
----------------
tra wrote:
> `const CodeGenModule &CGM`
Why doesn't the CGNVCUDARuntime just hold on to a reference to the CGM?  That's what we do with all the other separated singletons (like the CGCXXABI), and it would let you avoid some of the redundant fields like Context and TheModule.


https://reviews.llvm.org/D44984