[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 19 23:08:55 PDT 2018


baloghadamsoftware added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:148
+          Name.endswith_lower(".cc") || Name.endswith_lower(".m") ||
+          Name.endswith_lower(".mm")) {
+        return true;
----------------
Although not very common, but .cxx is also a possibly extension for C++ source files.


================
Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:837
             return false;
 
       // Conditionally control the inlining of the destructor of C++ shared_ptr.
----------------
Maybe we should include a test for container methods as well.


https://reviews.llvm.org/D45839





More information about the cfe-commits mailing list