[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

[Alex Bradbury via Phabricator via cfe-commits]

asb added a comment.

Hi @spetrovic - I think Hal Finkel's earlier request to update the comments of IsBetterAsSingleFieldRun remains unaddressed. It looks like at least the comment string immediately before `auto IsBetterAsSingleFieldRun` needs to be updated to reflect the changed behaviour.

The documentation `-ffine-grained-bitfield-accesses` option may also need to be updated. Iit currently reads "Use separate accesses for bitfields with legal widths and alignments.". I think "Use separate accesses for consecutive bitfield runs with legal widths and alignments" might better reflect the behaviour after this patch. Do you agree?


https://reviews.llvm.org/D39053