[PATCH] D45373: [clang-format] Don't remove empty lines before namespace endings

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 19 05:18:06 PDT 2018


krasimir marked an inline comment as done.
krasimir added inline comments.


================
Comment at: lib/Format/NamespaceEndCommentsFixer.h:24
 
+// Finds the namespace token corresponding to a closing namespace `}`, if that
+// is to be formatted.
----------------
djasper wrote:
> I don't understand the "if that is to be formatted part". What do you mean?
I'm documenting the current behavior of the implementation, getting into more detail in the next paragraph of the comments: this returns `nullptr` if `Line` is not `Affected`, even if otherwise would have a namespace token.


Repository:
  rC Clang

https://reviews.llvm.org/D45373





More information about the cfe-commits mailing list