[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 18 15:21:20 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Headers/waitpkgintrin.h:41
+static __inline__ __UINT8_TYPE__ __DEFAULT_FN_ATTRS
+_umwait (__UINT32_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER)
+{
----------------
I think we should use "unsigned int" and "unsigned long long" explciitly. I think that's the prevailing behavior in the rest of our headers.

Also change the argument names to lower case. I think that's also pretty standard.


https://reviews.llvm.org/D45254





More information about the cfe-commits mailing list