[PATCH] D45489: [HIP] Add input type for HIP

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 18 08:49:43 PDT 2018


yaxunl added a comment.

In https://reviews.llvm.org/D45489#1070929, @yaxunl wrote:

> In https://reviews.llvm.org/D45489#1070470, @tra wrote:
>
> > I'm getting confused about the order of the patches. 
> >  The patch stack phabricator displays in this patch is different compared to the stack in https://reviews.llvm.org/D44984. Which one should I trust?
>
>
> Sorry I think I may misunderstand the parent/child relation between reviews. I thought a review depends on its parent reviews, i.e., parent reviews should be committed first. Is that correct? Thanks.


I think it is just visual difference. The relations are the same.


https://reviews.llvm.org/D45489





More information about the cfe-commits mailing list