[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 17 13:51:48 PDT 2018


rnk added a comment.

Sorry, I skipped over the message and looked at the code, which seems pretty straightforward.

> Tests still are TBD, but posting this early to see if there's comments. (How do I easily do a test that checks something relative to the clang binary, since I don't control the location of the tested binary when running tests?)

As much fun as it is to create sysroot subtrees in the clang test input directories and test them with -###, I don't feel like they have that much value. I've seen people write tests that do things like `mkdir -p %t/bin ... cp %clang %t/bin/clang && %t/bin/clang -###`, but it's pretty expensive, and the tests are hard to debug and modify.


https://reviews.llvm.org/D45504





More information about the cfe-commits mailing list