[PATCH] D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 17 03:23:40 PDT 2018


alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

Thank you for investigating and fixing this!

One comment re: the test below.



================
Comment at: test/clang-tidy/read_file_config.cpp:5
+// RUN: echo '[{"command": "cc -c -o test.o test.cpp", "directory": "%T/read-file-config", "file": "%T/read-file-config/test.cpp"}]' > %T/read-file-config/compile_commands.json
+// RUN: clang-tidy %T/read-file-config/test.cpp | not grep "clang-analyzer-*"
+
----------------
Please add a sanity check to ensure the code triggers the static analyzer check, when enabled explicitly: 

// RUN: clang-tidy -checks=-*,clang-analyzer-* %T/read-file-config/test.cpp | grep "clang-analyzer-*"


(hint: it won't pass, since your regex in grep is incorrect ;)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45697





More information about the cfe-commits mailing list