[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

Henry Wong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 14 03:01:34 PDT 2018


MTC added a comment.

In https://reviews.llvm.org/D45491#1067852, @NoQ wrote:

> Yeah, i think this makes sense, thanks! It feels a bit weird that we have to add it as an exception - i wonder if there are other exceptions that we need to make. Widening over the stack memory space should be a whitelist, not a blacklist, because we can easily enumerate all stack variables and see which of them can be modified at all from the loop. But until we have that, this looks like a reasonable workaround.


You are right , it's really weird. And the better solution, D36690 <https://reviews.llvm.org/D36690#change-BqbIHiVwl2WX>, seems to be blocked.


Repository:
  rC Clang

https://reviews.llvm.org/D45491





More information about the cfe-commits mailing list