[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 13 00:17:00 PDT 2018


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

I'd still prefer if someone with more driver-design expertise weighed in, but we might not have any specialists there.

LGTM, although you might consider changing your tests a bit: FileCheck recently added support for a -D argument where you can predefine variables in the command line.  But that's just a suggestion, not something I'm asking you to do as part of review.


https://reviews.llvm.org/D45212





More information about the cfe-commits mailing list