[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a comment.

Hi, thanks for adding this.

Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included in the next release of the ACLE.



================
Comment at: lib/Basic/Targets/AArch64.h:36
   unsigned HasFullFP16;
+  unsigned HasDotProd;
   llvm::AArch64::ArchKind ArchKind;
----------------
Does this need to be initialised (and set to false)?


================
Comment at: test/Preprocessor/aarch64-target-features.c:94
+// -dM %s -o - | FileCheck --check-prefix=CHECK-DOTPROD %s
+// CHECK-DOTPROD: __ARM_FEATURE_DOTPROD 1
+
----------------
Perhaps one additional check it's not enabled?


https://reviews.llvm.org/D45544