[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 11 21:50:00 PDT 2018


smeenai added a comment.

This LGTM given that Eric accepted your previous change. I'm happy to accept it in a day or two if he hasn't gotten the chance to take a look by then.



================
Comment at: libcxx/CMakeLists.txt:101
+if (FUCHSIA)
+  set(ABI_VERSION_DEFAULT 2)
+else()
----------------
I prefer `DEFAULT_ABI_VERSION` to `ABI_VERSION_DEFAULT`


Repository:
  rCXX libc++

https://reviews.llvm.org/D45529





More information about the cfe-commits mailing list