[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

Gabor Buella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 07:59:10 PDT 2018


GBuella added a comment.

In https://reviews.llvm.org/D45488#1063067, @davezarzycki wrote:

> I don't think this change is correct. To the best of my knowledge, SKL does support SGX but SKX does not.


llvm-lit test/Preprocessor/predefined-arch-macros.c passes now.
I didn't know tests are not run automatically precommit around here, now I know I must always check them manually... sorry


https://reviews.llvm.org/D45488





More information about the cfe-commits mailing list