[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 06:55:05 PDT 2018


aaron.ballman added inline comments.


================
Comment at: lib/Basic/Targets/PPC.h:349
     LongLongAlign = 32;
+    UseSignedCharForObjCBool = true;
     resetDataLayout("E-m:o-p:32:32-f64:32:64-n32");
----------------
Do you need to specify this? Isn't it handled by the `TargetInfo` constructor?


================
Comment at: lib/Basic/Targets/PPC.h:364
     HasAlignMac68kSupport = true;
+    UseSignedCharForObjCBool = true;
     resetDataLayout("E-m:o-i64:64-n32:64");
----------------
Likewise.


https://reviews.llvm.org/D29768





More information about the cfe-commits mailing list