[PATCH] D45479: [Tooling] Optimize memory usage in InMemoryToolResults.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

This definitely helps with memory consumption of clangd's global-symbol-indexer, I can now run it over LLVM on MacBook without it swapping out of RAM. The physical memory usage goes up to 3GB at some point, before it was > 20GB.

Strictly speaking, interning the strings is probably more work for some workloads, so I'm not sure it's a better in all cases.
On average this LG, though, so LGTM from my side.


Repository:
  rC Clang

https://reviews.llvm.org/D45479