[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 10 02:53:54 PDT 2018


hokein added a comment.

Thanks for digging it out!

In upstream, we use `InMemoryToolResults` which saves all duplicated "std::string"s into the memory, I think we could optimize `InMemoryToolResults` by using Arena to keep the memory low, I will try it to see whether it can reduce the memory. A bonus point is that we don't need to change any client code.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45478





More information about the cfe-commits mailing list