[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 9 03:13:47 PDT 2018


lebedev.ri added a comment.

Ping.

@aaron.ballman ping, do you have any further thoughts on that macro false-negative?

  #define vardecl(type, name) type name;
  void variables_15() {
    // FIXME: surely we should still warn here?
    vardecl(int, a);
    vardecl(int, b);
  }
  // CHECK-MESSAGES: :[[@LINE-5]]:6: warning: function 'variables_15' exceeds recommended size/complexity thresholds [readability-function-size]
  // CHECK-MESSAGES: :[[@LINE-6]]:6: note: 4 lines including whitespace and comments (threshold 0)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44602





More information about the cfe-commits mailing list