[PATCH] D45285: [clangd-vscode] Update VScode dependencies

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 9 03:09:20 PDT 2018


hokein added a comment.

In https://reviews.llvm.org/D45285#1061243, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
>
> > Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?
>
>
> We should bump the version and republish the extension into VSCode marketplace. 
>  @hokein has more context on how to properly do that.


Once you commit this patch, I'm happy to make a new release.

> In https://reviews.llvm.org/D45285#1058578, @MaskRay wrote:
> 
>> Do we really want to keep editor plugins in the repository?
> 
> 
> As long as we are the ones who own it, probably yes. Any downsides to keeping it here?

We used to have a separate GitHub repository for the extension, but it increased the maintaining burden (we need to syn whenever a new change is made in this repository).
Having the vscode extension in the clangd repository is the sensible way IMO.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285





More information about the cfe-commits mailing list