[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 8 09:57:26 PDT 2018


theraven added a comment.

I think that we emit empty method lists so that the GCC runtime doesn't choke on them, though there's no reason why we couldn't with the GNUstep ABI.  It would therefore be nice if the test failed if we did change to emitting null so that we could update the test at that point and check that it's actually doing the right thing.

The ELF version of the v2 ABI is mostly finished now, modulo writing a load of clang tests, so I'll upload that for review soon.

It would also help to have a gnu- prefix on the test name so that it's easy to identify the relevant tests, though not essential.


Repository:
  rC Clang

https://reviews.llvm.org/D45305





More information about the cfe-commits mailing list