[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 3 14:02:03 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D45152#1056134, @rnk wrote:

> In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote:
>
> > In https://reviews.llvm.org/D45152#1055871, @rnk wrote:
> >
> > > Seems reasonable, looks good.
> >
> >
> > Any opinion on the wording of the option name?
>
>
> Maybe what we're trying to do is find the sysroot relative to clang, so an option name phrased along those lines makes more sense? --clang-in-sysroot-bin? --from-sysroot-bin? --assume-sysroot-bin? --in-sysroot-bin?


That sounds sensible - and positive options is often better than negated/ignore etc. I think I prefer `--assume-sysroot-bin` out of those.


Repository:
  rC Clang

https://reviews.llvm.org/D45152





More information about the cfe-commits mailing list