[PATCH] D45013: Generate warning when over-aligned new call is required but not supported.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 31 21:16:17 PDT 2018


EricWF added a comment.

In https://reviews.llvm.org/D45013#1052600, @vsapsai wrote:

> Does it make sense to have a warning for `__libcpp_deallocate` and `get_temporary_buffer` too? Not sure about deallocate as you have allocated memory already and allocation has a warning. So for deallocation a warning can be too noisy. But for `get_temporary_buffer` the warning seems reasonable, unless I'm missing something.


`get_temporary_buffer` shouldn't return a temporary buffer when the request is over-aligned and aligned allocation isn't available; so I don't think we should warn on it.


Repository:
  rCXX libc++

https://reviews.llvm.org/D45013





More information about the cfe-commits mailing list