[PATCH] D45054: Set dso_local on cfi_slowpath

Rafael Avila de Espindola via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 29 14:02:27 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D45054#1052118, @eugenis wrote:

> This looks wrong. cfi_slowpath is defined in libclang_rt.cfi, which is linked to the main executable. It is not always dso-local. On Android it is defined in libdl.so and is never dso-local.


And we don't set cfi_local in that case. See the ITANIUM lines is the testcase.

The CodegenModule functions are named setDSOLocal, setDLLImportDLLExport, etc, but they only set the corresponding flags when appropriate.


https://reviews.llvm.org/D45054





More information about the cfe-commits mailing list