[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

[George Burgess IV via Phabricator via cfe-commits]

george.burgess.iv added a comment.

Thanks!

> Will be good idea to clarify where TEMP_FAILURE_RETRY come from.

Updated the CL summary and added "TEMP_FAILURE_RETRY is a macro provided by both glibc and Bionic." to ComparisonInTempFailureRetryCheck.h. Did you have anything else in mind?



================
Comment at: docs/clang-tidy/checks/bugprone-comparison-in-temp-failure-retry.rst:6
+
+Checks whether a use of ``TEMP_FAILURE_RETRY`` has a top-level comparison in its
+argument. Having such a use is incorrect in the vast majority of cases, and
----------------
Eugene.Zelenko wrote:
> Please make first statement same as in Release Notes.
Interpreted "statement" as "sentence". Please let me know if you meant to include "Having such a use...", as well


https://reviews.llvm.org/D45059