[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

[Rafael Stahl via Phabricator via cfe-commits]

r.stahl added inline comments.
Herald added a subscriber: martong.


================
Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:100
 
+  // This traverses the AST to catch certain bugs like poorly or not
+  // implemented subtrees.
----------------
a.sidorin wrote:
> I just saw this change and I cannot find the reason, why do we need to print the imported declaration after we have printed the entire translation unit? Is there some special case?
Sorry for the late reply.

The particular bug here would only be detected when dumping, but not when printing. The output of printing was just not listing the missing AST nodes, but dumping crashed and therefore failed the test as expected.

I'm not familiar with the inner workings of print and dump, so I cannot explain why that is.


Repository:
  rL LLVM

https://reviews.llvm.org/D38943