[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 26 08:54:54 PDT 2018


alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.


================
Comment at: docs/clang-tidy/checks/bugprone-parent-virtual-call.rst:26
+  int foo() override {... A::foo()...}
+                          ^^^^^^^^ warning: qualified name A::foo refers to a
+                                            member which was overridden in 
----------------
alexfh wrote:
> The formatting looks weird. Could you move `warning: .*` to the start of the next line and put the whole message on the same line?
Could you address the "and put the whole message on the same line" part as well?

Please also put `// ` before `warning:` and `...`s to make the example look more like syntactically valid code.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44295





More information about the cfe-commits mailing list