[PATCH] D44272: [clangd] Support incremental document syncing

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 26 01:51:40 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: unittests/clangd/DraftStoreTests.cpp:1
+//===-- DraftStoreTests.cpp - Clangd unit tests -----------------*- C++ -*-===//
+//
----------------
NIT: s/Clangd unit tests/Draft store tests
Or remove the comment title altogether, the filename seems to provide the same information.



================
Comment at: unittests/clangd/DraftStoreTests.cpp:20
+
+using namespace llvm;
+
----------------
It seems this `using namespace` can be removed (at least there are lots of names qualified with `llvm::` throughout the file)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44272





More information about the cfe-commits mailing list