[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 22 16:11:36 PDT 2018


alexfh added a comment.

In https://reviews.llvm.org/D44778#1046301, @alexfh wrote:

> In https://reviews.llvm.org/D44778#1046251, @rnk wrote:
>
> > Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale.
>
>
> I vaguely remember that windows console applications have to define wmain() instead of main() in order to work with unicode. Does `llvm::sys::Process::GetArgumentVector` allow to work around this?


Never mind. I looked at the windows implementation and see how =)

Thanks for the pointer. I'll update the patch.


Repository:
  rC Clang

https://reviews.llvm.org/D44778





More information about the cfe-commits mailing list