[PATCH] D44673: Make positionToOffset return llvm::Expected<size_t>

[Simon Marchi via Phabricator via cfe-commits]

simark marked 6 inline comments as done.
simark added inline comments.


================
Comment at: clangd/ClangdServer.cpp:199
+    return End.takeError();
+
+  return formatCode(Code, File, {tooling::Range(*Begin, *End - *Begin)});
----------------
ilya-biryukov wrote:
> NIT: unnecessary empty line
In general I like spacing out the different logical blocks of code a little bit, especially after a "return", but I don't mind removing them.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44673