[clang-tools-extra] r328069 - Revert "[lit] Adding config initialization to lit tests in clang-tools-extra"

Roman Lebedev via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 21 01:53:35 PDT 2018


On Wed, Mar 21, 2018 at 5:28 AM, Petr Hosek via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: phosek
> Date: Tue Mar 20 19:28:22 2018
> New Revision: 328069
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328069&view=rev
> Log:
> Revert "[lit] Adding config initialization to lit tests in clang-tools-extra"
>
> This reverts commit r328060 because a test that was inteded to run on
> Windows but never ran before due to the missing config initialization
> is now being executed and is failing.
Only one test?
Would it be possible to just completely disable that test for now?
Since it has never run, it's not like it is crucial for the CI...

This revision is the only thing that is blocking https://reviews.llvm.org/D41102

> Modified:
>     clang-tools-extra/trunk/test/lit.site.cfg.in
>
> Modified: clang-tools-extra/trunk/test/lit.site.cfg.in
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/lit.site.cfg.in?rev=328069&r1=328068&r2=328069&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/test/lit.site.cfg.in (original)
> +++ clang-tools-extra/trunk/test/lit.site.cfg.in Tue Mar 20 19:28:22 2018
> @@ -23,7 +23,5 @@ except KeyError:
>      key, = e.args
>      lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key))
>
> - at LIT_SITE_CFG_IN_FOOTER@
> -
>  # Let the main config do the real work.
>  lit_config.load_config(config, "@CLANG_TOOLS_SOURCE_DIR@/test/lit.cfg")

Roman
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list