[PATCH] D44630: [ms] Parse #pragma optimize and ignore it behind its own flag

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 19 08:49:26 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: lib/Parse/ParsePragma.cpp:2970
+
+  if (Tok.isNot(tok::l_paren)) {
+    PP.Diag(Tok.getLocation(), diag::warn_pragma_expected_lparen) << "optimize";
----------------
One day, someone ought to refactor pragma parsing to be less verbose and error prone, but today is not that day.


https://reviews.llvm.org/D44630





More information about the cfe-commits mailing list