[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods
Zinovy Nis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 15 12:19:06 PDT 2018
zinovy.nis added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128
+ "'%0' is a grand-parent's method, not parent's. Did you mean %1?")
+ << CalleeName << ParentsStr;
> The diagnostic should not contain punctuation aside from the question mark.
> Also, the diagnostic uses some novel terminology in "grandparent's method". How about: "qualified function name %0 refers to a function that is not defined by a direct base class; did you mean %1?"
"is not defined by a direct base class" is not a correct proposal. Issues that this check finds are all about calling a grand-parent's method instead of parent's whether base class defines this method or not.
> Qualified function name %0 refers to a function not from a direct base class; did you mean %1?
rCTE Clang Tools Extra
More information about the cfe-commits