[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 16:11:42 PDT 2018

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with some minor documentation nits.

Comment at: docs/clang-tidy/checks/zircon-temporary-objects.rst:7
+Warns on construction of specific temporary objects in the Zircon kernel. 
+If the object should be flagged, the fully qualified name of the object 
+must be explicitly passed as a parameter to the check.
Nit: the docs conflate objects and types somewhat. The configuration specifies prohibited types, and objects of that type are the problem. How about: `If the object should be flagged, the fully qualified type name must be explicitly passed to the check.`

Comment at: docs/clang-tidy/checks/zircon-temporary-objects.rst:36-37
+Note that objects must be explicitly specified in order to be flagged, 
+and so objects that inherit a specified object will not be flagged.
Same problem here. How about: "This check matches temporary objects without regard for inheritance and so a prohibited base class type does not similarly prohibit derived class types."


More information about the cfe-commits mailing list