[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 14:14:07 PDT 2018


mstorsjo added inline comments.


================
Comment at: src/UnwindCursor.hpp:53
                                                unw_word_t fde, unw_word_t mh));
+  static void iterateSections(std::function<void (pint_t section)> func);
 
----------------
rnk wrote:
> I'm concerned that std::function might introduce runtime dependencies from libc++abi back to libc++. I think we get away with the <algorithm> include above because it's templated for the most part. Since this stuff is all in-header anyway, we could just take a non-type template parameter callable and call it directly.
Ok, will change.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D44494





More information about the cfe-commits mailing list