[PATCH] D41102: Setup clang-doc frontend framework

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang-doc/BitcodeWriter.cpp:230
+  prepRecordData(ID);
+  for (const char C : RecordIdNameMap[ID].Name) Record.push_back(C);
+  Stream.EmitRecord(llvm::bitc::BLOCKINFO_CODE_SETRECORDNAME, Record);
----------------
lebedev.ri wrote:
> Sadly, i can **not** prove it via godbolt (can't add LLVM as library), but i'd //expect// streamlining this should at least not hurt, i.e. something like
> ```
> Record.append(RecordIdNameMap[ID].Name.begin(), RecordIdNameMap[ID].Name.end());
> ```
> ?
And https://github.com/mattgodbolt/compiler-explorer/issues/841 is done,
so now we can see that `SmallVector::append()` at least results in less code:
https://godbolt.org/g/xJQ59c


Repository:
  rL LLVM

https://reviews.llvm.org/D41102