[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 12:52:45 PDT 2018

dblaikie added a comment.

Updated with a functional implementation - a few points:

- Some tests could use only the Common diagnostics (see one of the intermediate changes where I moved those tests over to use all diagnostics) except for the tablegen required for the diagnostic groups makes that a bit heavier - though doing so would help reduce dependencies.
- Naming (of the "DiagnosticTable" header, and the functions/entities contained there) could be improved - open to ideas
- API (currently passing in like 6 different raw arrays and ArrayRefs to DiagnosticIDs) could be improved - open to ideas

  rC Clang


More information about the cfe-commits mailing list