[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

Simon Marchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 11:12:23 PDT 2018

simark added a comment.

In https://reviews.llvm.org/D44408#1037327, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D44408#1036941, @simark wrote:
> > I don't see how to avoid adding the Contents parameter to the codeComplete and signatureHelp methods, since they needed to fetch the document from the draft manager and pass it to the backend.
> You can get the contents inside the `runWithPreamble` callback:
>   llvm::Expected<InputsAndPreamble> IP;
>   auto &Contents = IP->Inputs.Contents;

I see, I made this as a separate patch:


  rCTE Clang Tools Extra


More information about the cfe-commits mailing list