[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 10:09:14 PDT 2018

ilya-biryukov added inline comments.

Comment at: unittests/clangd/SyncAPI.h:23
+void runAddDocument(ClangdServer &Server, PathRef File, StringRef Contents,
+                    bool SkipCache = false);
sammccall wrote:
> it's slightly odd that wantdiagnostics is missing here. Previously this was "forwards compatible" and could easily be added later. But now we'll have callsites that pass different arguments than addDocument takes.
> Maybe just add the defaulted param to the signature?
Done. I thought it's slightly confusing to have both `Auto` and `Yes` for synchronous case, but being consistent with `addDocument` is a good cause to do this.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list