[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 14 05:20:19 PDT 2018
ilya-biryukov added a comment.
I also came up with a test case, but it breaks because of invalid errors when function bodies are skipped. I'll make sure to include it along with a fix for the errors in a follow-up patch.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3942
+ // FIXME: finishing the function body while in an expression evaluation
+ // context seems wrong. Investigate more.
> (hmm, not sure whether it's better to duplicate or not-duplicate this comment. up to you)
It looks relevant to both sites, so I'd probably keep it. It adds some noise, but it's better than having a chance of confusing someone by not including it.
More information about the cfe-commits