[PATCH] D43248: [Attr] Fix parameter indexing for attributes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 14:11:35 PDT 2018

aaron.ballman added a comment.

In https://reviews.llvm.org/D43248#1036409, @jdenny wrote:

> I'd prefer to move it than to expect people to obey such a comment.  Let's see what Aaron says.

I have a slight preference for moving the tests now that I know they're causing problems, unless that turns out to be overly onerous for some reason.

Thank you, @echristo for pointing out the issues with the tests, I hadn't considered that.

  rC Clang


More information about the cfe-commits mailing list