[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

Zinovy Nis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 13:45:02 PDT 2018

zinovy.nis marked an inline comment as done and an inline comment as not done.
zinovy.nis added inline comments.

Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:115
+  int virt_1() override { return A::virt_1(); }
+  // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's method, not parent's. Did you mean 'BF<F>'?
+  // CHECK-FIXES:  int virt_1() override { return BF<F>::virt_1(); }
malcolm.parsons wrote:
> There isn't an F in scope.
> The base class isn't a dependent type here, so no template params are needed.
Finally I decided not to propose a fix for templated parent.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list