[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 12:58:18 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGValue.h:234
     this->Quals = Quals;
     this->Alignment = Alignment.getQuantity();
     assert(this->Alignment == Alignment.getQuantity() &&
----------------
Please saturate Alignment here instead of allowing it to be truncated: that is, if the passed-in alignment is greater than (1U << 31), please store (1U << 31).


https://reviews.llvm.org/D44445





More information about the cfe-commits mailing list