[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 11:28:03 PDT 2018

Eugene.Zelenko added inline comments.

Comment at: docs/ReleaseNotes.rst:63
+  Detects inappropriate seeding of C++ random generators and C srand function.
Please replace srand  with ``srand ()``.

Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:7
+This check flags all pseudo-random number engines, engine adaptor
+instantiations and srand when initialized or seeded with default argument,
+constant expression or any user-configurable type. Pseudo-random number
aaron.ballman wrote:
> Backticks around `srand`
Two of them and please add (). Will be good idea to make first statement same as in Release Notes.

Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:29
+  }
Is there guideline documentation available online? If so, please add link. See other checks documentation as example.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list