[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 05:22:21 PDT 2018

ilya-biryukov added inline comments.

Comment at: clangd/XRefs.cpp:137
+          //
+          // FIXME: Exclude declarations from macros.
+          Decls.clear();
NIT: the fixme was a bit hard to follow for me. Maybe make it more clear where the problem should be handled, e.g. 
```FIXME: we should avoid adding decls from inside macros in handlDeclOccurence.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list