[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 13 03:59:52 PDT 2018

sdardis added a comment.

This patch looks mostly ok, but I think there are some small issues with it.

Can you separate the new warnings/error relating to -fno-pic / -mabicalls into another patch from the change which alters the behaviour of __PIC__ / __pic__ ?

The title of the patch is misleading, as you're adding warnings related to -fno-pic / -mabicalls and changing how __pic__ is defined.

  rC Clang


More information about the cfe-commits mailing list