[PATCH] D43248: [Attr] Fix parameter indexing for attributes

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 12 18:40:21 PDT 2018

jdenny added inline comments.

Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2
+// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse
+// it here to check -emit-ast for attributes.
aaron.ballman wrote:
> jdenny wrote:
> > aaron.ballman wrote:
> > > Can you move this below the RUN line?
> > Sure.  I'm still trying to learn the LLVM coding standards.  Is this specified there?
> Nope! I'm just used to looking at the very first line of the test to know what it's running, and that seems consistent with other tests.
OK, that makes sense.  I'll be sure to change both of those.


More information about the cfe-commits mailing list