[PATCH] D44093: [BUILTINS] structure pretty printer
Paul Semel via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 12 07:57:12 PDT 2018
paulsemel added a comment.
In https://reviews.llvm.org/D44093#1034610, @lebedev.ri wrote:
> BTW, as far as i can tell this still has zero test coverage (no new tests are being added).
> I'd expect to see the tests for the actual output
> - one struct per each type it is able to print
> - probably some tests showing error handling, and possibly the availability of the builtin is somehow tested, too?
Sure, I am going to work on it, now that the patch seems to be kind of "Okay" for its first version !
More information about the cfe-commits