[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 12 07:48:48 PDT 2018

ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.

Comment at: unittests/clangd/XRefsTests.cpp:587
-  const char *HeaderContents = R"cpp([[]]int a;)cpp";
+  const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_
+                                     #define TEST_H_
hokein wrote:
> ilya-biryukov wrote:
> > I would go with `#pragma once` in the test code, it adds less noise. WDYT?
> I thought `#pragma once` is non-standard, but the diagnostic message also suggest this fix. Changed to it.
Thanks! It's non-standard, but supported on every modern compiler, so we should be fine :-)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list