[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 9 13:58:48 PST 2018

arsenm added a comment.

In https://reviews.llvm.org/D43281#1023962, @dfukalov wrote:

> The problem is that if set addrspace "2" in description string, CanT.getAddressSpace() returns target addrspace value "11" (shifted in the enum) and compares it with input LangAS addrspace ("2", "opencl_local" in our case).
>  So I cannot set a number a description string that will be equal to LangAS addrspace "opencl_local".
> Moreover, this change is preparation to move to custom processing of these builtins. Then I'm going to remove link (GCCBuiltin in IntrinsicsAMDGPU.td) from the llvm intrinsics definitions. Then I'll be able to switch on custom processing in cfe.

My real question was what happens if you put 11 in the description string?

  rC Clang


More information about the cfe-commits mailing list